Skip to content

Fix pylint for the main package #3658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2017
Merged

Fix pylint for the main package #3658

merged 1 commit into from
Jul 24, 2017

Conversation

theacodes
Copy link
Contributor

NOTE: Pylint is still failing against tests, I have a longer-term strategy to address this which I'll propose later.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 24, 2017
dhermes
dhermes approved these changes Jul 24, 2017
View reviewed changes
core/google/cloud/_http.py
:raises: Exception if the response code is not 200 OK.
:raises ~google.cloud.exceptions.GoogleCloudError: if the response code
is not 200 OK.
:raises TypeError: if the response content type is not JSON.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/_testing.py
from __future__ import absolute_import


class _Monkey(object):
# context-manager for replacing module names in the scope of a test.
"""Context-manager for replacing module names in the scope of a test."""

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/_testing.py
@@ -68,8 +66,12 @@ def _tempdir_mgr():
return _tempdir_mgr


# pylint: disable=invalid-name
# Retain _tempdir as a constant for backwards compatibility despite

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/client.py
@@ -64,7 +64,7 @@ def from_service_account_json(cls, json_credentials_path, *args, **kwargs):

:rtype: :class:`_ClientFactoryMixin`
:returns: The client created with the retrieved JSON credentials.
:raises: :class:`TypeError` if there is a conflict with the kwargs
:raises TypeError: if there is a conflict with the kwargs
and the credentials created by the factory.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

core/google/cloud/iterator.py
@@ -242,7 +242,8 @@ def _page_iter(self, increment):
results per page while an items iterator will want
to increment per item.

Yields :class:`Page` instances.
:rtype: :class:`Page`
:returns: pages

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes theacodes merged commit 506a304 into googleapis:master Jul 24, 2017
@theacodes theacodes deleted the fix-core-lint branch July 24, 2017 21:09
@dhermes dhermes mentioned this pull request Aug 4, 2017
Merged
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 21, 2017
@landrito
Fix pylint for the main package (googleapis#3658)
52aac47
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Fix pylint for the main package (googleapis#3658)
54ee13b
landrito pushed a commit to landrito/google-cloud-python that referenced this pull request Aug 22, 2017
@landrito
Fix pylint for the main package (googleapis#3658)
0a014eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes dhermes approved these changes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theacodes @dhermes @googlebot