Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove setup.cfg configuration for creating universal wheels #13659

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Mar 14, 2025

The file setup.cfg contains a setting to create a Universal Wheel which is only needed if libraries support both Python 2 and Python 3. Python Cloud Client Libraries only support Python 3 so this setting is no longer needed. See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels.

This will resolve the following warning in this build log from PR #13644:

Building wheels for collected packages: googleapis-common-protos
  Building wheel for googleapis-common-protos (pyproject.toml): started
  Building wheel for googleapis-common-protos (pyproject.toml): finished with status 'error'
  error: subprocess-exited-with-error
  
  × Building wheel for googleapis-common-protos (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [40349 lines of output]
      running bdist_wheel
      /tmp/pip-build-env-9o_3w17v/overlay/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
      !!
      
              ********************************************************************************
              With Python 2.7 end-of-life, support for building universal wheels
              (i.e., wheels that support both Python 2 and Python 3)
              is being obviated.
              Please discontinue using this option, or if you still need it,
              file an issue with pypa/setuptools describing your use case.
      
              By 2025-Aug-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.
              ********************************************************************************
      
      !!

@parthea parthea requested a review from a team as a code owner March 14, 2025 12:18
parthea added a commit to googleapis/google-api-python-client that referenced this pull request Mar 14, 2025
`setup.cfg` contains a setting to create a `Universal Wheel` which is only needed if libraries support both Python 2 and Python 3. This library only supports Python 3 so this setting is no longer needed. See https://packaging.python.org/en/latest/guides/distributing-packages-using-setuptools/#wheels.

See similar PR googleapis/google-cloud-python#13659 which includes this stack trace

```
      running bdist_wheel
      /tmp/pip-build-env-9o_3w17v/overlay/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:135: SetuptoolsDeprecationWarning: bdist_wheel.universal is deprecated
      !!
      
              ********************************************************************************
              With Python 2.7 end-of-life, support for building universal wheels
              (i.e., wheels that support both Python 2 and Python 3)
              is being obviated.
              Please discontinue using this option, or if you still need it,
              file an issue with pypa/setuptools describing your use case.
      
              By 2025-Aug-30, you need to update your project and remove deprecated calls
              or your builds will no longer be supported.
              ********************************************************************************
      
      !!
```
This was referenced Mar 14, 2025
@parthea parthea merged commit 59bfd42 into main Mar 14, 2025
19 of 20 checks passed
@parthea parthea deleted the remove-universal-wheels branch March 14, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants