Skip to content

Pool: fix call to '_get_instance'. #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2018
Merged

Pool: fix call to '_get_instance'. #57

merged 1 commit into from
Dec 19, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 19, 2018

Lint error, see PR #56.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. release blocking Required feature/issue must be fixed prior to next release. labels Dec 19, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@tseaver tseaver requested a review from crwilcox December 19, 2018 16:25
@tseaver tseaver mentioned this pull request Dec 19, 2018
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Dec 19, 2018

Merging without review: the bug is obvious by inspection, as is the fix, and we need to unblock #56.

@tseaver tseaver merged commit fb30702 into master Dec 19, 2018
@tseaver tseaver deleted the 56-pool-fix_call_to__get_instance branch December 19, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. release blocking Required feature/issue must be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @googlebot