Fixing broken System test #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. updated Connection.create_table() to pass column families dict to low_level_table. 4. Updated unit tests.
googlebot
added
the
cla: yes
|
System tests still failing on python 3.x, working fine with python 2.x. I forgot to run system tests on py3.x. |
|
@tseaver made changes to make system-tests running with py3.x. Most of the changes are related to str to bytes conversion. |
|
@googleapis/yoshi-python, can someone please review this? |
|
@tseaver Can you please review this PR. |
|
@googleapis/yoshi-python, can we please get a review? |
tseaver
suggested changes
Dec 12, 2018
unit_tests/test_table.py
Outdated
| @@ -474,7 +474,7 @@ def mock_cells_to_pairs(*args, **kwargs): | |||
| col_fam = 'cf1' | |||
| qual = 'qual' | |||
| fake_cells = object() | |||
| partial_row._cells = {col_fam: {qual: fake_cells}} | |||
| partial_row._cells = {col_fam: {qual.encode(): fake_cells}} | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@sumit-ql, it looks like there are some follow up comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also partially fix the issue #45