Skip to content

Update scan method to use row set #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 21, 2018
Merged

Update scan method to use row set #42

merged 8 commits into from
Sep 21, 2018

Conversation

sumit-ql
Copy link
Contributor

  1. Updated scan method to use row set
  2. Updated rows() method to use read_rows() instead of yield_rows().

tseaver
tseaver suggested changes Sep 19, 2018
View reviewed changes
unit_tests/test_table.py Outdated
row_set.add_row_range(RowRange(row_start, row_stop))

def mock_get_row_set_object(*args):
return row_set

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor

tseaver commented Sep 19, 2018

@sumit-ql the test failure appears to be inaccessible due to the move of this repo from GoogleCloudPlatform to googleapis. I think we wil get the link back when you push again.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 20, 2018
sduskis
sduskis reviewed Sep 20, 2018
View reviewed changes
unit_tests/test_table.py

row_set = self._callFUT(start_key, end_key)
self.assertIsInstance(row_set, RowSet)

This comment was marked as spam.

Sign in to view

AVaksman
AVaksman reviewed Sep 21, 2018
View reviewed changes
src/google/cloud/happybase/table.py Outdated
"""Return a RowSet object for the given row_start and row_stop
"""
row_set = RowSet()
row_set.add_row_range(RowRange(row_start, row_stop))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit 24de0cb into googleapis:master Sep 21, 2018
@tseaver tseaver mentioned this pull request Sep 21, 2018
Merged
@tseaver tseaver mentioned this pull request Oct 10, 2018
Closed
@sumit-ql sumit-ql deleted the update_scan_method_to_use_RowSet branch October 18, 2018 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis left review comments

@AVaksman AVaksman AVaksman left review comments

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sumit-ql @tseaver @sduskis @AVaksman @googlebot