chore: license checking in posttest #2785
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can't be checked in until a license issue with `@google-cloud/common-grpc` is fixed. It has a transitive dependency, `jsonify`, which has "Public Domain" as its license. But Public Domain is not a valid license for Google's open source projects. Also the 'log-driver' package is whitelisted. Additonal minor changes: - add the `version` field: this is a required field - fix the `private` field: this is a boolean field. "true" --> true. - package-lock.json is committed.
googlebot
added
the
cla: yes
|
The license checking fails due to |
|
Huh? All CI tests passed, which is unexpected. They should've failed in the Looking at the test setup, it looks like none of the tests are actually run. Test scripts just run lint and the build script. Is this intended? |
|
@stephenplusplus Can you check the CI setup? None of the tests seem to run on CI. |
lukesneeringer
requested review from
alexander-fenster
and removed request for
lukesneeringer
|
Hey @jinwoo, we just branched common-grpc out into its own repo: https://github.com/googleapis/nodejs-common-grpc. Can you add the license checking changes there? I'm not sure what the fate of this repo will be, but that was the last bit of code we had here. |
stephenplusplus
removed
the
cla: yes
|
Got it. Branching out common-grpc seems like the way to go. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can't be checked in until a license issue with
@google-cloud/common-grpcis fixed. It has a transitive dependency,jsonify, which has "Public Domain" as its license. But Public Domainis not a valid license for Google's open source projects.
Also the 'log-driver' package is whitelisted.
Additonal minor changes:
versionfield: this is a required fieldprivatefield: this is a boolean field. "true" --> true.