Skip to content

bigtable/table/createReadStream: allow early ending #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bigtable/table/createReadStream: allow early ending #2276

wants to merge 1 commit into from

Conversation

stephenplusplus
Copy link
Contributor

Fixes #2271

@stephenplusplus stephenplusplus added the api: bigtable Issues related to the Bigtable API. label May 4, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2017
@stephenplusplus stephenplusplus mentioned this pull request May 4, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-14.6%) to 85.36% when pulling 28ee925 on stephenplusplus:spp--2271 into 0362106 on GoogleCloudPlatform:master.

@stephenplusplus
Copy link
Contributor Author

That doesn't seem right, @coveralls.

callmehiphop
callmehiphop reviewed May 5, 2017
View reviewed changes
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - do we also need to do this in sampleRowKeys?

@stephenplusplus
Copy link
Contributor Author

This is turning out to be a bit of a problem. Marking as do not merge until I can get to the bottom of this.

jgeewax
jgeewax reviewed May 15, 2017
View reviewed changes
packages/bigtable/system-test/bigtable.js
@@ -510,7 +509,7 @@ describe('Bigtable', function() {
it('should get rows', function(done) {
TABLE.getRows(function(err, rows) {
assert.ifError(err);
assert.strictEqual(rows.length, 4);
assert(rows.length >= ROWS.length);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus removed the cla: yes This human has signed the Contributor License Agreement. label Dec 12, 2017
@stephenplusplus
Copy link
Contributor Author

Carried on in googleapis/nodejs-bigtable#18

@stephenplusplus stephenplusplus deleted the spp--2271 branch December 12, 2017 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgeewax jgeewax jgeewax left review comments

@callmehiphop callmehiphop callmehiphop left review comments

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stephenplusplus @coveralls @jgeewax @callmehiphop @googlebot