Skip to content

Generate gapic client for language v1beta2 #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

landrito
Copy link
Contributor

@landrito landrito commented Apr 4, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 4, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 99.924% when pulling e48d2f5 on landrito:language into 6f39cb4 on GoogleCloudPlatform:master.

@lukesneeringer
Copy link
Contributor

@landrito I think the coverage change is because you are out of date on your local master. Can you merge master into your PR and push again?

@landrito
Copy link
Contributor Author

landrito commented Apr 4, 2017

Done!

@stephenplusplus
Copy link
Contributor

Is there documentation on this versioning scheme, I couldn't find any. I would have thought v1beta2 preceded v1, but we already have v1. Just want to confirm that we didn't make a mistake somewhere, and our v1 was actually a beta as well.

Also, will we drop the current v1 when we switch our code to use v1beta2, or do we leave the versions around for users to access directly (not using the handwritten layer)?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling de2f439 on landrito:language into 6f39cb4 on GoogleCloudPlatform:master.

@lukesneeringer
Copy link
Contributor

lukesneeringer commented Apr 4, 2017

Is there documentation on this versioning scheme, I couldn't find any. I would have thought v1beta2 preceded v1, but we already have v1. Just want to confirm that we didn't make a mistake somewhere, and our v1 was actually a beta as well.

There is mass confusion on this question. Yes, v1beta2 follows v1. We are trying to determine how we are going to handle this for client libraries because you are about the 74,819th person to ask this. It is clearly not intuitive. :-)

@stephenplusplus stephenplusplus added the api: language Issues related to the Cloud Natural Language API API. label Apr 5, 2017
@stephenplusplus
Copy link
Contributor

Gotcha, thanks! Just some questions about how to handle the version update, because this PR changes v1 source content as well as adds a new directory for v1beta2 content.

  • should we drop v1 the directory and the access points in our code to it?
  • are we switching our handwritten code to use v1beta2 now?

@lukesneeringer
Copy link
Contributor

The answers to that are: No, and no.
What we landed on was just dropping v1beta2 in and not making any changes to the manual layer at all except to add it to module.exports as a separate thing people can get it.

I ended up doing this in #2188 (d'oh, sorry @landrito), and that PR supercedes this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: language Issues related to the Cloud Natural Language API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants