-
Notifications
You must be signed in to change notification settings - Fork 616
language: re-work encoding property #2054
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -44,8 +44,6 @@ var prop = require('propprop'); | |||
* object to specify the encoding and/or language of the document, use this | |||
* property to pass the inline content of the document or a Storage File | |||
* object. | |||
* @param {string} options.encoding - `UTF8`, `UTF16`, or `UTF32`. See | |||
* [`EncodingType`](https://cloud.google.com/natural-language/reference/rest/v1/EncodingType). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Added a minor comment.
ca36baf
to
94cb07a
Compare
@monattar thanks for the review! @callmehiphop PTAL. |
Changes Unknown when pulling 94cb07a on stephenplusplus:spp--2018 into ** on GoogleCloudPlatform:master**. |
Fixes #2018
encoding
andencodingType
are allowed.To Dos
@monattar could you please take a look?
#2018 explained that
encodingType
was not a value attached to a document. But, the "Document" object that we have in our API is just meant to cache content that will be used again for future analysis. So, since the "Document" holds the value, it seems like a fine place to set the encoding type (by the user or by us, using defaults). By not allowing users to set it at the time of Document creation, we are forcing them to set it each time they make a method call, even though the encodingType should be the same each time-- right?