fix(util): broken URL to auth docs #1918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://googlecloudplatform.github.io/google-cloud-node/#//docs/guides/authentication opens https://googlecloudplatform.github.io/google-cloud-node/#/ and not the auth docs removing the extra `/` properly routes to https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud/0.45.0/guides/authentication Relates to googleapis#1405
googlebot
added
the
cla: yes
|
Thank you! Which browser are you using? The original link works for me, as well as the new one, so it shouldn't be a problem to merge. Just want to make sure we're solving the real problem. |
|
Chrome |
|
Added the current link as a clickable link in the PR description to make sure that you were testing with the right link. |
|
Sorry for my delay, too. And thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current link in this message opens https://googlecloudplatform.github.io/google-cloud-node/#/ and not the auth docs.
Removing the extra
/properly routes to https://googlecloudplatform.github.io/google-cloud-node/#/docs/google-cloud/0.45.0/guides/authenticationRelates to #1405