bigquery: assign record type for nested schemas #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Looks like there are a few linting issues per Travis. |
|
That was an issue we merged to master. It's fixed now! |
|
Instead of blitzing Travis, I just ran against Node stable. Feel free to restart the others. |
|
Should there be some sort of documentation/example stating we support nested schemas? Or was it already assumed/documented and we just didn't implement it correctly..? |
|
It's more like an implementation detail that only matters if the user didn't know to put it in the right place. Kind of like an API that accepts a "jsonPayload" or "textPayload"-- we detect "did we get an object? Okay, send this as |
|
Gotcha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1422