Skip to content

compute: implement HealthChecks #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 3, 2016
Merged

compute: implement HealthChecks #1276

merged 6 commits into from
May 3, 2016

Conversation

stephenplusplus
Copy link
Contributor

@stephenplusplus stephenplusplus commented May 1, 2016 •
edited
Loading

@stephenplusplus stephenplusplus added api: compute Issues related to the Compute Engine API. don't merge labels May 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 1, 2016
@callmehiphop callmehiphop mentioned this pull request May 1, 2016
Closed
20 tasks
@stephenplusplus stephenplusplus force-pushed the spp--1073-health-checks branch 2 times, most recently from 76b405f to b8bf85e Compare May 1, 2016 19:49
@stephenplusplus stephenplusplus force-pushed the spp--1073-health-checks branch from b8bf85e to 873b88e Compare May 2, 2016 13:37
@coveralls
Copy link

coveralls commented May 2, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 873b88e on stephenplusplus:spp--1073-health-checks into e9e4170 on GoogleCloudPlatform:master.

@callmehiphop
Copy link
Contributor

Can we get a docs preview?

@stephenplusplus stephenplusplus force-pushed the spp--1073-health-checks branch from 873b88e to ffd2de0 Compare May 2, 2016 20:53
@stephenplusplus
Copy link
Contributor Author

Yep: http://stephenplusplus.github.io/gcloud-node/#/docs/master/compute/health-check

Though, the sidebar link tries to load ".../healthCheck"

callmehiphop
callmehiphop reviewed May 2, 2016
View reviewed changes
docs/toc.json
@@ -62,6 +62,9 @@
"title": "Firewall",
"type": "compute/firewall"
}, {
"title": "Health Check",
"type": "compute/healthCheck"

This comment was marked as spam.

Sign in to view

@stephenplusplus
Copy link
Contributor Author

Good call, docs work! http://stephenplusplus.github.io/gcloud-node/#/docs/master/compute/health-check

@stephenplusplus
Copy link
Contributor Author

Oh, just realized the rest of our API uses camelcase, e.g. common/grpcServiceObject -- should we just convert those to hyphenates, or find another way to have the docs support the camelcase?

@stephenplusplus
Copy link
Contributor Author

stephenplusplus commented May 2, 2016 •
edited
Loading

Went with hyphenation.

@coveralls
Copy link

coveralls commented May 3, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a2b3b21 on stephenplusplus:spp--1073-health-checks into 7d8e203 on GoogleCloudPlatform:master.

@callmehiphop callmehiphop merged commit 276c847 into googleapis:master May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephenplusplus @coveralls @callmehiphop @googlebot