storage: delete versioned files #1147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
api: storage
googlebot
added
the
cla: yes
Closed
callmehiphop
added a commit
that referenced
this pull request
Mar 2, 2016
storage: delete versioned files
| // } | ||
| callback(); | ||
| }); | ||
| bucket.delete(done); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #968 (possibly)
I can't positively say all of the ghost buckets had versioning enabled... but if they did, the explanation for not being able to delete them is we didn't delete old versions of the files. That makes sense to me!
In the after hook for the Storage system tests, this will now get all versions of a file from each bucket, so they will be deleted.