-
Notifications
You must be signed in to change notification settings - Fork 616
Binary messages are unsupported by the js pubsub API #987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
api: pubsub
Issues related to the Pub/Sub API.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
Thanks for reporting this. That sounds like a logical way to deal with this to me. Any chance you're willing to throw a PR together? |
Sure, I am just working on it now. |
Fixed in #988 - thanks again! |
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
* docs: Clarify boost usage in Reference PiperOrigin-RevId: 504332057 Source-Link: googleapis/googleapis@13dd16c Source-Link: googleapis/googleapis-gen@75a668a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzVhNjY4YTA1ZjVlNDM4ZmJjMDEwNWM4NTQzM2FlMTgxZWYzN2VjMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this issue
Jan 25, 2023
* docs: Clarify boost usage in Reference PiperOrigin-RevId: 504332057 Source-Link: googleapis/googleapis@13dd16c Source-Link: googleapis/googleapis-gen@75a668a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzVhNjY4YTA1ZjVlNDM4ZmJjMDEwNWM4NTQzM2FlMTgxZWYzN2VjMCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcf-owl-bot bot
added a commit
that referenced
this issue
Mar 13, 2025
Source-Link: googleapis/googleapis@2753fe1 Source-Link: googleapis/googleapis-gen@8472eeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6Ijg0NzJlZWJhYTIxMDNjYjFlMjc4NmViMTFlMzQ2NGRkNWVhNzQyMjMifQ==
gcf-owl-bot bot
added a commit
that referenced
this issue
Mar 14, 2025
Source-Link: googleapis/googleapis@2753fe1 Source-Link: googleapis/googleapis-gen@8472eeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6Ijg0NzJlZWJhYTIxMDNjYjFlMjc4NmViMTFlMzQ2NGRkNWVhNzQyMjMifQ==
sofisl
pushed a commit
that referenced
this issue
Mar 18, 2025
…#6155) * feat: Update Compute Engine API to revision 20250302 (#987) Source-Link: googleapis/googleapis@2753fe1 Source-Link: googleapis/googleapis-gen@8472eeb Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6Ijg0NzJlZWJhYTIxMDNjYjFlMjc4NmViMTFlMzQ2NGRkNWVhNzQyMjMifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the Pub/Sub API.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Messages pulled from pubsub using the subscription API are converted from base 64 to UTF 8
https://github.com/GoogleCloudPlatform/gcloud-node/blob/master/lib/pubsub/subscription.js#L298
This is fine for messages that are serialized to strings but for binary data round trips to/from UTF 8 doesn’t work http://haacked.com/archive/2012/01/30/hazards-of-converting-binary-data-to-a-string.aspx/
If there was an encoding option that defaults to
utf8
, receiving binary data e.g. protobuf data from a java app would be possible (currently I am having to use a fork to get this working).I would recommend an option like so
The text was updated successfully, but these errors were encountered: