Skip to content

Elevate access level of CollectionReference to support mocking #6054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

schmidt-sebastian
Copy link
Contributor

Follow up to #3562

@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #6054 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6054      +/-   ##
============================================
- Coverage     47.43%   47.43%   -0.01%     
- Complexity    27180    27187       +7     
============================================
  Files          2522     2522              
  Lines        274264   274299      +35     
  Branches      31355    31355              
============================================
+ Hits         130095   130110      +15     
- Misses       134559   134575      +16     
- Partials       9610     9614       +4
Impacted Files Coverage Δ Complexity Δ
...om/google/cloud/firestore/CollectionReference.java 50% <ø> (ø) 10 <0> (ø) ⬇️
.../cloud/automl/v1beta1/PredictionServiceClient.java 43.95% <0%> (-0.69%) 18% <0%> (+7%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f1c514...f5001c2. Read the comment docs.

@schmidt-sebastian schmidt-sebastian merged commit 6add88e into master Aug 13, 2019
@schmidt-sebastian schmidt-sebastian deleted the schmidt-sebastian-patch-1 branch August 13, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants