fix deadlock in testStreamAckDeadlineUpdate #1581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1577. The detailed description of the bug is available in the issue. This commit fixes the bug by ensuring that the Future received by MessageReceiver cannot be completed before a callback is added to it.
googlebot
added
the
cla: yes
|
LGTM, but let @davidtorres take a look too. |
davidtorres
reviewed
Feb 1, 2017
| */ | ||
| ListenableFuture<AckReply> receiveMessage(PubsubMessage message); | ||
| void receiveMessage(PubsubMessage message, SettableFuture<AckReply> response); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@garrettjonesgoogle is right that adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @davidtorres
Fixes #1577. The detailed description of the bug is available in the
issue.
This commit fixes the bug by ensuring that the Future received by
MessageReceiver cannot be completed before a callback is added to it.
@garrettjonesgoogle I know that we are moving away from exposing Guava types. Since this branch has not been moved to
RpcFutureyet, I think it's best to keep using Guava types for now. I'm mostly afraid that moving types might change the timing just enough that this bug become more difficult to reproduce.