do not expose Service #1553
do not expose Service #1553
Conversation
googlebot
added
the
cla: yes
|
@garrettjonesgoogle Please take a look. If possible, I'd like to merge this ASAP, since everything we do will conflict with this change. |
|
It's hard to figure out what has changed and what has moved - can you point me to the points in the PR that need to actually be considered? |
|
@garrettjonesgoogle Essentially, all fields (non static ones) and all methods are moved into the inner |
| logger.debug("Starting subscriber group."); | ||
| startStreamingConnections(); | ||
| notifyStarted(); | ||
| public enum State { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| TERMINATED | ||
| } | ||
|
|
||
| public abstract static class SubscriberListener { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
…s#1687) (googleapis#1553) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <[email protected]> Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a
I'm not sure how ready this PR is. The general logic is to hide the implementation in a subclass then create a delegator. If the approach looks fine to you, I'll go ahead and document the methods.