Skip to content

clean up doc #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2017
Merged

clean up doc #1524

merged 2 commits into from
Jan 12, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jan 12, 2017

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2017
@pongad pongad changed the title fix doc annotations fix doc annotations, fix spelling typo Jan 12, 2017
- PUBSUB_API_ADDRESS and PUBSUB_API_SCOPE are removed.
  We now use {Publisher,Subscriber}Settings instead.
- Default settings are moved into the Builder class,
  so that they have package-private visibility.
  We can make them public later if we want to.
- Subscriber doc is fixed so that it is not chopped off mid-sentence.
- Subscriber doc mistakenly referred to the Publisher. This is now
  fixed.
@pongad pongad changed the title fix doc annotations, fix spelling typo clean up doc Jan 12, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c33722f on pongad:fix-anno into ** on GoogleCloudPlatform:pubsub-rm**.

@garrettjonesgoogle
Copy link
Member

LGTM

@pongad pongad merged commit c3ded9d into googleapis:pubsub-rm Jan 12, 2017
@pongad pongad deleted the fix-anno branch January 12, 2017 22:28
github-actions bot pushed a commit that referenced this pull request Oct 4, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants