Skip to content

Delete handwritten PubSub layer #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 12, 2017
Merged

Delete handwritten PubSub layer #1520

merged 3 commits into from
Jan 12, 2017

Conversation

pongad
Copy link
Contributor

@pongad pongad commented Jan 11, 2017

You have no idea how happy this PR makes me

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 11, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 58928d1 on pongad:pubsub-rm into ** on GoogleCloudPlatform:pubsub-rm**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3a559cc on pongad:pubsub-rm into ** on GoogleCloudPlatform:pubsub-rm**.

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 11, 2017
View reviewed changes
google-cloud-examples/src/main/java/com/google/cloud/examples/pubsub/PubSubExample.java
}

@SuppressWarnings("unchecked")
public static void main(String... args) throws Exception {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/testing/LocalPubSubHelperTest.java
assertSame(NoCredentials.getInstance(), options.getCredentials());
}

@Test
public void testStartStopReset() throws IOException, InterruptedException, TimeoutException {
LocalPubSubHelper helper = LocalPubSubHelper.create();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle reviewed Jan 11, 2017
View reviewed changes
google-cloud-pubsub/src/test/java/com/google/cloud/pubsub/testing/LocalPubSubHelperTest.java
public void testStartStopReset() throws IOException, InterruptedException, TimeoutException {
LocalPubSubHelper helper = LocalPubSubHelper.create();
helper.start();
PubSub pubsub = helper.getOptions().getService();
pubsub.create(TopicInfo.of(TOPIC));
assertNotNull(pubsub.getTopic(TOPIC));

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Member

LGTM

@pongad pongad merged commit 5f1417c into googleapis:pubsub-rm Jan 12, 2017
@pongad pongad deleted the pubsub-rm branch January 12, 2017 00:24
github-actions bot pushed a commit that referenced this pull request Sep 30, 2022
@diegomarquezp
Revert "chore: pin versions of dependencies for compatibility with Py…
28755a5 
…thon 3.6 (#1588)" (#1520)

Reverts googleapis/java-bigquerydatatransfer#1495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle left review comments

Assignees

@garrettjonesgoogle garrettjonesgoogle

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pongad @coveralls @garrettjonesgoogle @googlebot