-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make TableDataWriteChannel expose Job when upload completed #1395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make TableDataWriteChannel expose Job when upload completed #1395
Conversation
/cc @tswast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
(Can we tell codacy-bot to ignore unused locals in snippets?)
It is doable but configuration is not exactly easy. |
@garrettjonesgoogle do you want to have a look? |
@lesv PTAL |
So the argument for not using |
…13.3 (#1395) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-bigquery](https://togithub.com/googleapis/java-bigquery) | `2.13.2` -> `2.13.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-bigquery</summary> ### [`v2.13.3`](https://togithub.com/googleapis/java-bigquery/blob/HEAD/CHANGELOG.md#​2133-httpsgithubcomgoogleapisjava-bigquerycomparev2132v2133-2022-06-16) [Compare Source](https://togithub.com/googleapis/java-bigquery/compare/v2.13.2...v2.13.3) ##### Bug Fixes - Assertj-core cleanup ([#​2102](https://togithub.com/googleapis/java-bigquery/issues/2102)) ([4630c50](https://togithub.com/googleapis/java-bigquery/commit/4630c50db7428d888b726297408b7a223b39b28a)) ##### Documentation - **sample:** clean up native image sample README ([#​2120](https://togithub.com/googleapis/java-bigquery/issues/2120)) ([de7b45a](https://togithub.com/googleapis/java-bigquery/commit/de7b45a52259cec16970e074dd4f526685aa4d09)) ##### Dependencies - update cloud client dependencies ([#​2110](https://togithub.com/googleapis/java-bigquery/issues/2110)) ([30a88f4](https://togithub.com/googleapis/java-bigquery/commit/30a88f43aea6269e3fbe82544eb2112f25830761)) - update dependency com.google.cloud:google-cloud-datacatalog-bom to v1.8.2 ([#​2101](https://togithub.com/googleapis/java-bigquery/issues/2101)) ([bdbd3da](https://togithub.com/googleapis/java-bigquery/commit/bdbd3da4c6c8bb7f2363711691edb31c7711d811)) - update dependency com.google.oauth-client:google-oauth-client-java6 to v1.34.1 ([#​2111](https://togithub.com/googleapis/java-bigquery/issues/2111)) ([1a0235f](https://togithub.com/googleapis/java-bigquery/commit/1a0235f9cdea0ae37b2e8b1047ca66395b1af3b0)) - update dependency com.google.oauth-client:google-oauth-client-jetty to v1.34.1 ([#​2112](https://togithub.com/googleapis/java-bigquery/issues/2112)) ([e52739f](https://togithub.com/googleapis/java-bigquery/commit/e52739ffcaeb9ca9dc362f07f117f37ecff220c7)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigquerydatatransfer).
🤖 I have created a release *beep* *boop* --- ## [2.2.5](googleapis/java-bigquerydatatransfer@v2.2.4...v2.2.5) (2022-06-21) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.13.3 ([#1395](googleapis/java-bigquerydatatransfer#1395)) ([c8c7f3f](googleapis/java-bigquerydatatransfer@c8c7f3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…1.3 (googleapis#1395) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTkuMSIsInVwZGF0ZWRJblZlciI6IjMyLjIxOS4xIn0=-->
This fixes #1392