Prevent integer overflow when reading large blobs #1093
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
position
instance variable ofBlobReadChannel
overflows when reading blobs with size larger thanInteger.MAX_VALUE
. This results in a request against the storage api with an invalidRange
header.The api ignores the invalid range header, which results in the the entire file being downloaded. When an array is allocated to hold the contents of the file, the runtime throws an
OutOfMemoryError
.The issue can be reproduced as follows:
Create a large random file
Confirm the file size is greater than
Integer.MAX_VALUE
Create a bucket and upload the file
Use
com.google.cloud.examples.storage.StorageExample
to download the fileResult: