chore: use api_shortname in OwlBot.yaml's api_name (#8999)

When generating new OwlBot.yaml file, use api_shortname
as api_name field of the file.

This is the command to list bad file we recently created:
find . -name '.OwlBot.yaml' |xargs grep 'api-name: java-'

Author: suztomo

generation/new_client/new-client.py

@@ -236,7 +236,8 @@ def generate(
         output_name=str(workdir / owlbot_yaml_location_from_module),
         artifact_name=distribution_name_short,
         proto_path=proto_path,
-        module_name=f"java-{output_name}"
+        module_name=f"java-{output_name}",
+        api_shortname=api_shortname
     )
 
     # get the sha256 digets for the owlbot image

generation/new_client/templates/owlbot.yaml.monorepo.j2

@@ -33,4 +33,4 @@ deep-copy-regex:
   dest: "/owl-bot-staging/{{ module_name }}/$1/samples/snippets/generated"
 {% endif %}
 
-api-name: {{ module_name }}
+api-name: {{ api_shortname }}

java-discoveryengine/.OwlBot.yaml

@@ -32,4 +32,4 @@ deep-copy-regex:
 - source: "/google/cloud/discoveryengine/(v.*)/.*-java/samples/snippets/generated"
   dest: "/owl-bot-staging/java-discoveryengine/$1/samples/snippets/generated"
 
-api-name: java-discoveryengine
+api-name: discoveryengine

java-enterpriseknowledgegraph/.OwlBot.yaml

@@ -32,4 +32,4 @@ deep-copy-regex:
 - source: "/google/cloud/enterpriseknowledgegraph/(v.*)/.*-java/samples/snippets/generated"
   dest: "/owl-bot-staging/java-enterpriseknowledgegraph/$1/samples/snippets/generated"
 
-api-name: java-enterpriseknowledgegraph
+api-name: enterpriseknowledgegraph

java-maps-addressvalidation/.OwlBot.yaml

@@ -32,4 +32,4 @@ deep-copy-regex:
 - source: "/google/maps/addressvalidation/(v.*)/.*-java/samples/snippets/generated"
   dest: "/owl-bot-staging/java-maps-addressvalidation/$1/samples/snippets/generated"
 
-api-name: java-maps-addressvalidation
+api-name: maps-addressvalidation

java-maps-routing/.OwlBot.yaml

@@ -32,4 +32,4 @@ deep-copy-regex:
 - source: "/google/maps/routing/(v.*)/.*-java/samples/snippets/generated"
   dest: "/owl-bot-staging/java-maps-routing/$1/samples/snippets/generated"
 
-api-name: java-maps-routing
+api-name: maps-routing

java-monitoring-metricsscope/.OwlBot.yaml

@@ -32,4 +32,4 @@ deep-copy-regex:
 - source: "/google/monitoring/metricsscope/(v.*)/.*-java/samples/snippets/generated"
   dest: "/owl-bot-staging/java-monitoring-metricsscope/$1/samples/snippets/generated"
 
-api-name: java-monitoring-metricsscope
+api-name: monitoring-metricsscope

java-vmwareengine/.OwlBot.yaml

@@ -32,4 +32,4 @@ deep-copy-regex:
 - source: "/google/cloud/vmwareengine/(v.*)/.*-java/samples/snippets/generated"
   dest: "/owl-bot-staging/java-vmwareengine/$1/samples/snippets/generated"
 
-api-name: java-vmwareengine
+api-name: vmwareengine