Skip to content

Commit f1f845f

Browse files
authored
chore(docs): update new client generation step for snapshot Release Please PR (#8995)
* chore(docs): update new client generation step for snapshot Release Please PR * chore(docs): add a step to record the command * Update README.md
1 parent b0b9eb0 commit f1f845f

File tree

1 file changed

+16
-0
lines changed

1 file changed

+16
-0
lines changed

generation/new_client/README.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,20 @@ Use Linux environment.
1717

1818
Install Docker.
1919

20+
### Ensure no Release Please "snapshot" pull request open
21+
22+
Ensure google-cloud-java repository does not have [a pull request with "autorelease: snapshot" label](
23+
https://github.com/googleapis/google-cloud-java/pulls?q=is%3Apr+is%3Aopen+label%3A%22autorelease%3A+snapshot%22).
24+
25+
If you find one, merge it after approving it.
26+
This is a pull request to append "-SNAPSHOT" to versions in pom.xml files in the
27+
repostiory. It's not for an actual release.
28+
29+
Background: This new client library generation process creates pom.xml files with
30+
a "-SNAPSHOT" version. To have consistency with other modules, ensure the pom.xml files in
31+
the repository has "-SNAPSHOT" versions too.
32+
33+
2034
### Checkout google-cloud-java repository
2135

2236
```
@@ -175,6 +189,8 @@ Please create a pull request:
175189
```
176190

177191
Create a pull request from the change.
192+
In the description, record the `python3.9 generation/new_client/new-client.py generate ...`
193+
command you ran above.
178194

179195
## Advanced Options
180196

0 commit comments

Comments
 (0)