Skip to content

chore(deps): Update google.golang.org/grpc dependency #11284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

fasmat
Copy link
Contributor

@fasmat fasmat commented Dec 13, 2024

Closes #11283

This required me to drop Go 1.21 as oldest supported version. The latest to Go versions (1.22 and 1.23) are still supported.

@fasmat fasmat requested review from jba, eliben, a team and shollyman as code owners December 13, 2024 10:08
@fasmat fasmat requested a review from daniel-sanche December 13, 2024 10:08
@fasmat fasmat force-pushed the update-grpc-dependency branch 2 times, most recently from b2bff54 to 4f37ecd Compare December 13, 2024 10:11
@fasmat fasmat force-pushed the update-grpc-dependency branch from 4f37ecd to 41eb4fc Compare December 13, 2024 10:23
@codyoss
Copy link
Member

codyoss commented Dec 13, 2024

@fasmat This is intentional today as we still support 3 Go version for another month. Please see: https://github.com/googleapis/google-cloud-go?tab=readme-ov-file#go-versions-supported

Closing as by design(for now).

@codyoss codyoss closed this Dec 13, 2024
@fasmat
Copy link
Contributor Author

fasmat commented Dec 13, 2024

@codyoss thanks for your response! Shall I re-open this PR in January? 🙂

@codyoss
Copy link
Member

codyoss commented Dec 13, 2024

@fasmat I think we will take care of it as a larger project, but thank you for offering to make the contribution. It will be on the top of our todo list in the new year :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: problematic dependency resolution with stats
2 participants