run: Invalid default endpoint for service

[murarustefaan]

Client

cloud.google.com/go/run/apiv2.NewLocationsClient(...)

Environment

e.g. Alpine Docker on GKE
MacOS development environment (redundant, it's sdk related)

e.g. $ go version
1.24.3

Code and Dependencies

package run

import (
	v2 "cloud.google.com/go/run/apiv2"
	locationpb "google.golang.org/genproto/googleapis/cloud/location"
)

func fetchLocations(ctx context.Context, meta schema.ClientMeta, _ *schema.Resource, res chan<- any) error {
	c := meta.(*client.Client)
	gcpClient, err := v2.NewLocationsClient(ctx, c.ClientOptions...)
	if err != nil {
		return err
	}
	it := gcpClient.ListLocations(ctx, &locationpb.ListLocationsRequest{Name: "projects/" + c.ProjectId}, c.CallOptions...)
	return client.Iterate(ctx, it, c, res)
}

Expected behavior

The locations fetched by the SDK call above to be the regions where the Cloud Run API is supported for the given project.

Actual behavior

The API call above returns a full list of locations, including regional, zonal as well as the continent.

Additional context

This happens due to the fact that the DefaultEndpoint for the locations client is cloud.googleapis.com:443, rather than run.googleapis.com:443. Setting the option.WithEndpoint("run.googleapis.com:443") when instantiating the v2.NewLocationsClient(ctx, c.ClientOptions...) above solves the issue.

However, due to the fact that

1. the CLI returns the regions supported by Cloud Run and
2. Cloud Run is also a regional service
   i believe that by default the endpoint should always be run.googleapis.com:443.

Thanks in advance for any feedback you might have!

[quartzmo]

@murarustefaan Thank you for reporting this issue. The google.api.default_host in the service.proto is indeed run.googleapis.com, and yet the DefaultEndpoint in locations_client.go is cloud.googleapis.com. I will investigate.

[quartzmo]

locations_client.go was previously identified and marked in #8093 with the following message:

Some client files that exist in actively generated packages are frozen because either they shouldn't have been generated in the first place or the proto file/service was removed from the package without a breaking change being taken.

This comment is meant to help us identify such files later for manual updates.

It appears that we can fix the incorrect endpoint simply by directly updating this file. I will prepare a PR.

[murarustefaan]

That's good to hear, thanks for the fast response!

Let me know if I can help in any way.

[quartzmo]

@murarustefaan This is actually a rare chance to make a simple and straightforward contribution to this repo, if you want to open the PR. I did not start work on it. You will need to complete the Google CLA. It looks like 8 lines total need to be updated: All instances of cloud. in defaultLocationsGRPCClientOptions and defaultLocationsRESTClientOptions need to be changed to run..

If this is not something that you want to do, no problem. I will get it done this week.

[murarustefaan]

Yeah definitely, I opened #12399. I also tested the changeset in the original project using replace.

Let me know if there's anything needed to push this trough.