Skip to content

datastore: incorrect documentation on order of LoadKey vs. Load #12323

Open
@daboyuka

Description

@daboyuka

Client

Datastore

Environment

any

Code and Dependencies

N/A

Expected behavior

Documentation here should indicate that when KeyLoader is implemented, LoadKey is called before Load. Also, it should note that if an error occurs in LoadKey, Load is still called, but the LoadKey error takes priority to return.

Actual behavior

Documentation indicates LoadKey is called after Load and makes no mention of error handling.

Screenshots

N/A

Additional context

The behavior was intentionally changed to the expected behavior above in #1575, but documentation was not updated.

Metadata

Metadata

Assignees

Labels

api: datastoreIssues related to the Datastore API.triage meI really want to be triaged.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions