Skip to content

storage: opentelemetry dependency broken #11455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flowerinthenight opened this issue Jan 16, 2025 · 4 comments
Closed

storage: opentelemetry dependency broken #11455

flowerinthenight opened this issue Jan 16, 2025 · 4 comments
Assignees
Labels
api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.

Comments

@flowerinthenight
Copy link

flowerinthenight commented Jan 16, 2025

Client

storage

Environment

Done on a Linux box.

$ go env
GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/f14t/tmp/gocache'
GOENV='/home/f14t/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/f14t/gopath/pkg/mod'
GONOPROXY='github.com/mobingilabs/*,github.com/alphauslabs/*'
GONOSUMDB='github.com/mobingilabs/*,github.com/alphauslabs/*'
GOOS='linux'
GOPATH='/home/f14t/gopath'
GOPRIVATE='github.com/mobingilabs/*,github.com/alphauslabs/*'
GOPROXY='https://proxy.golang.org'
GOROOT='/home/f14t/sdk/go1.23.3'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/f14t/sdk/go1.23.3/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23.3'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/f14t/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2520783649=/tmp/go-build -gno-record-gcc-switches'

Code and Dependencies

$ go get -u cloud.google.com/go/storage
go: cloud.google.com/go/storage imports
        google.golang.org/grpc/stats/opentelemetry: ambiguous import: found package google.golang.org/grpc/stats/opentelemetry in multiple modules:
        google.golang.org/grpc v1.69.4 (/home/f14t/gopath/pkg/mod/google.golang.org/[email protected]/stats/opentelemetry)
        google.golang.org/grpc/stats/opentelemetry v0.0.0-20241028142157-ada6787961b3 (/home/f14t/gopath/pkg/mod/google.golang.org/grpc/stats/[email protected])
@flowerinthenight flowerinthenight added the triage me I really want to be triaged. label Jan 16, 2025
@flowerinthenight flowerinthenight changed the title packagename: short description of bug storage: opentelemetry dependency broken Jan 16, 2025
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 16, 2025
@aplr
Copy link

aplr commented Jan 17, 2025

I've removed the following line from all my go.mod and run go clean -modcache. Afterwards, go mod tidy stopped complaining about the ambigous import.

	google.golang.org/grpc/stats/opentelemetry v0.0.0-20240907200651-3ffb98b2c93a // indirect

Different version of google.golang.org/grpc/stats/opentelemetry for me, but similar error.

@flowerinthenight
Copy link
Author

Tried the same but go mod tidy puts the deleted lines back again.

daniel-weisse added a commit to edgelesssys/constellation that referenced this issue Jan 20, 2025
This is required to avoid issues with a broken
google.golang.org/grpc/stats/opentelemetry import
See googleapis/google-cloud-go#11455

Signed-off-by: Daniel Weiße <[email protected]>
daniel-weisse added a commit to edgelesssys/constellation that referenced this issue Jan 20, 2025
* deps: update Go dependencies

* keep cloud.google.com/go/storage at v1.49.0

This is required to avoid issues with a broken
google.golang.org/grpc/stats/opentelemetry import
See googleapis/google-cloud-go#11455

* deps: tidy all modules

---------

Signed-off-by: Daniel Weiße <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Daniel Weiße <[email protected]>
Co-authored-by: edgelessci <[email protected]>
@codyoss
Copy link
Member

codyoss commented Jan 21, 2025

Please see: #11283 (comment) and let us know if that fixes the issues.

@flowerinthenight
Copy link
Author

That worked, thanks.

First, remove the google.golang.org/grpc/stats/opentelemetry line(s) from go.mod, then

go get -u google.golang.org/grpc
go get -u cloud.google.com/go/storage

@codyoss codyoss closed this as completed Jan 22, 2025
@tritone tritone added type: question Request for information or clarification. Not an issue. and removed triage me I really want to be triaged. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

4 participants