Skip to content

Handle an uninitialised appender #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2017
Merged

Handle an uninitialised appender #900

merged 2 commits into from
Mar 17, 2017

Conversation

chrisdunelm
Copy link
Contributor

Updates #893

jskeet
jskeet approved these changes Mar 17, 2017
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There may be some subtle memory model issues here - not sure. The OnClose could probably just use _logUploader?.Close() - but in general I'm fine with this.

apis/Google.Cloud.Logging.V2/Google.Cloud.Logging.Log4Net.Tests/Log4NetTest.cs
};
appender = null;
// This should not cause an error on AppenderSkeleton finalization.
GC.Collect();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chrisdunelm chrisdunelm merged commit 98a1944 into googleapis:master Mar 17, 2017
@chrisdunelm chrisdunelm deleted the log4netnre branch March 17, 2017 15:58
gcf-owl-bot bot added a commit that referenced this pull request May 7, 2024
@gcf-owl-bot
feat: Update Compute Engine API to revision 20240430 (#900)
03c8bee 
Source-Link: googleapis/googleapis@3820562

Source-Link: googleapis/googleapis-gen@a2cd2c3
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYTJjZDJjM2JhY2JmOWFlY2Y3ZGQxZjg4NDUwYTZhMTQ1N2UyNDM4YSJ9
gcf-owl-bot bot added a commit that referenced this pull request May 7, 2024
@gcf-owl-bot
feat: Update Compute Engine API to revision 20240430 (#900)
4db7162 
Source-Link: googleapis/googleapis@3820562

Source-Link: googleapis/googleapis-gen@a2cd2c3
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYTJjZDJjM2JhY2JmOWFlY2Y3ZGQxZjg4NDUwYTZhMTQ1N2UyNDM4YSJ9
gcf-owl-bot bot added a commit that referenced this pull request May 7, 2024
@gcf-owl-bot
feat: Update Compute Engine API to revision 20240430 (#900)
022b880 
Source-Link: googleapis/googleapis@3820562

Source-Link: googleapis/googleapis-gen@a2cd2c3
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYTJjZDJjM2JhY2JmOWFlY2Y3ZGQxZjg4NDUwYTZhMTQ1N2UyNDM4YSJ9
amanda-tarafa pushed a commit that referenced this pull request May 8, 2024
@gcf-owl-bot @amanda-tarafa
feat: Update Compute Engine API to revision 20240430 (#900)
95da052 
Source-Link: googleapis/googleapis@3820562

Source-Link: googleapis/googleapis-gen@a2cd2c3
Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuQ2xvdWQuQ29tcHV0ZS5WMS8uT3dsQm90LnlhbWwiLCJoIjoiYTJjZDJjM2JhY2JmOWFlY2Y3ZGQxZjg4NDUwYTZhMTQ1N2UyNDM4YSJ9
jskeet added a commit that referenced this pull request May 8, 2024
@jskeet
Release Google.Cloud.Compute.V1 version 2.16.0
502c7e4 
Changes in this release:

### New features

- Update Compute Engine API to revision 20240430 ([issue 900](#900)) ([commit 95da052](95da052))
- Update Compute Engine API to revision 20240421 ([issue 899](#899)) ([commit cc0431c](cc0431c))
- Update Compute Engine API to revision 20240407 ([issue 890](#890)) ([commit ee6c6f0](ee6c6f0))
- Add IServiceCollection extension methods for client registration where an IServiceProvider is required. ([commit 022fab2](022fab2))
@jskeet jskeet mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees

@jskeet jskeet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisdunelm @jskeet