Skip to content

Reuse trace test servers when possible and fix flakiness of Trace_QPS . #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 17, 2017

Conversation

iantalarico
Copy link
Contributor

  • Reuses trace test servers when possible.
  • Change the logic in Trace_QPS to be more robust.

These changes will reduce test run time and fix some test flakiness.

- Reuses trace test servers when possible.
- Change the logic in Trace_QPS to be more robust.
@iantalarico iantalarico added the api: cloudtrace Issues related to the Cloud Trace API. label Mar 16, 2017
@iantalarico iantalarico requested review from jskeet and evildour March 16, 2017 18:14
@evildour
Copy link
Contributor

You may need to rebase master. AppVeyor has an error that the UploadObjectWithSessionUri snippet can't be found, which I just added in #890.

Copy link
Contributor

@evildour evildour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the build issues are fixed. If you are already merged with the latest and there are still issues, ping me and I'll see if its something I caused.

@iantalarico
Copy link
Contributor Author

@evildour I'm already merged with the latest bits, I'll take a closer look.

@iantalarico
Copy link
Contributor Author

@evildour it looks like this failure started in #890. Although looking at the PR I'm not sure why. It looks correct.

@iantalarico
Copy link
Contributor Author

@jskeet @evildour Getting off topic but I tried to build the docs locally but wasn't quite sure what to do. Do we have something to generate docfx.jsons?

@evildour
Copy link
Contributor

I haven't tried building them locally, but I think I see what the problem is. About to submit a PR and will merge if it fixes the issue.

Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a risk of test interdependence by reusing the servers? I generally prefer the isolation given by each test having a separate srever - on the other hand, if it's causing issues either in terms of taking a long time or causing quota failures, I can see how this is desirable...

@iantalarico
Copy link
Contributor Author

I don't think we will run into interdependence if we reuse the server as long as we clean the work space up. However, I also don't see a reason to reuse them if we don't have too.

@iantalarico iantalarico merged commit ecddb51 into googleapis:master Mar 17, 2017
@iantalarico iantalarico deleted the integration-tests-quota branch March 17, 2017 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudtrace Issues related to the Cloud Trace API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants