-
Notifications
You must be signed in to change notification settings - Fork 386
Reuse trace test servers when possible and fix flakiness of Trace_QPS . #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse trace test servers when possible and fix flakiness of Trace_QPS . #891
Conversation
Also adds a test to check for this.
- Reuses trace test servers when possible. - Change the logic in Trace_QPS to be more robust.
You may need to rebase master. AppVeyor has an error that the UploadObjectWithSessionUri snippet can't be found, which I just added in #890. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming the build issues are fixed. If you are already merged with the latest and there are still issues, ping me and I'll see if its something I caused.
@evildour I'm already merged with the latest bits, I'll take a closer look. |
I haven't tried building them locally, but I think I see what the problem is. About to submit a PR and will merge if it fixes the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a risk of test interdependence by reusing the servers? I generally prefer the isolation given by each test having a separate srever - on the other hand, if it's causing issues either in terms of taking a long time or causing quota failures, I can see how this is desirable...
I don't think we will run into interdependence if we reuse the server as long as we clean the work space up. However, I also don't see a reason to reuse them if we don't have too. |
These changes will reduce test run time and fix some test flakiness.