Allows to use GCE service credentials to sign blobs (#141) #150

dtretyakov · 2018-02-27T00:59:26Z

This change allows to use GCE service credentials to get a signature.

googlebot · 2018-02-27T00:59:28Z

Thanks for your pull request. t looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

dtretyakov · 2018-02-27T01:01:42Z

I signed it!

googlebot · 2018-02-27T01:01:44Z

CLAs look good, thanks!

nbali · 2018-05-24T12:54:11Z

@jadekler any estimation when will this be checked/merged?

jeanbza · 2018-05-24T14:30:49Z

Hi @nbali; we're unfortunately critically short staffed at the moment, and my cycles are being spent elsewhere. I'll see if I can find an appropriate reviewer for this; I'm happy to release it after review.

credentials/java/com/google/auth/ServiceAccountSigner.java

@@ -69,7 +70,7 @@ public int hashCode() {
  /**
   * Returns the service account associated with the signer.
   */
-  String getAccount();
+  String getAccount() throws IOException;


oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java

-import com.google.api.client.http.HttpRequest;
-import com.google.api.client.http.HttpResponse;
-import com.google.api.client.http.HttpStatusCodes;
+import com.google.api.client.http.*;


oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java

@@ -57,13 +59,16 @@
 *
 * <p>Fetches access tokens from the Google Compute Engine metadata server.
 */
-public class ComputeEngineCredentials extends GoogleCredentials {
+public class ComputeEngineCredentials extends GoogleCredentials implements ServiceAccountSigner {


* Don't change ServiceAccountSigner method signatures * Use complete list of imports in ComputeEngineCredentials

garrettjonesgoogle · 2018-06-04T15:14:56Z

@vchudnov-g could you take a look?

nbali · 2018-06-20T23:58:22Z

@vchudnov-g ping?

oss92 · 2018-07-02T11:36:34Z

Any updates regarding whether this PR will ever be merged?

chingor13

Functionality looks great!

We've added several failure cases that don't have tests for. Can we add a few more test cases here and we'll get this merged?

oauth2_http/javatests/com/google/auth/oauth2/ComputeEngineCredentialsTest.java

@@ -53,6 +46,8 @@
 import java.util.List;
 import java.util.Map;

+import static org.junit.Assert.*;


oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java


  private static final Logger LOGGER = Logger.getLogger(ComputeEngineCredentials.class.getName());

  // Note: the explicit IP address is used to avoid name server resolution issues.
  static final String DEFAULT_METADATA_SERVER_URL = "http://169.254.169.254";

+  static final String IAM_API_ROOT_URL = "https://iam.googleapis.com/v1";


Adding GCE signature PR tests

chingor13

Thank you!

Allows to use GCE service credentials to sign blobs (#141)

bd969d2

Fix failing test (#141)

ebb4823

dtretyakov mentioned this pull request Feb 27, 2018

GCE metadata server credentials cannot sign storage blob #141

Closed

Improve error reporting (#141)

47a9342

nbali mentioned this pull request May 24, 2018

Storage.signUrl() fails with default credentials in java8 standard runtime googleapis/google-cloud-java#2629

Closed

garrettjonesgoogle reviewed May 24, 2018

View reviewed changes

dtretyakov and others added 2 commits May 28, 2018 10:48

Fix issues for code review (#141)

be8a05d

* Don't change ServiceAccountSigner method signatures * Use complete list of imports in ComputeEngineCredentials

Merge branch 'master' into master

a24bedf

garrettjonesgoogle requested a review from vchudnov-g June 4, 2018 15:15

chingor13 self-assigned this Jul 2, 2018

Merge branch 'master' into master

b1b7c04

chingor13 reviewed Jul 3, 2018

View reviewed changes

chingor13 and others added 4 commits July 10, 2018 13:54

Restore individual assert imports

9c6e468

No need for IAM_API_ROOT_URL constant

b229e40

Add tests for failure cases

73b73d3

Merge pull request #1 from chingor13/gce-signature-pr-tests

2d8feb3

Adding GCE signature PR tests

chingor13 approved these changes Jul 12, 2018

View reviewed changes

chingor13 merged commit 8964e7c into googleapis:master Jul 12, 2018

google-admin unassigned chingor13 Sep 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allows to use GCE service credentials to sign blobs (#141) #150

Allows to use GCE service credentials to sign blobs (#141) #150

dtretyakov commented Feb 27, 2018

googlebot commented Feb 27, 2018

dtretyakov commented Feb 27, 2018

googlebot commented Feb 27, 2018

nbali commented May 24, 2018

jeanbza commented May 24, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

garrettjonesgoogle commented Jun 4, 2018

nbali commented Jun 20, 2018

oss92 commented Jul 2, 2018

chingor13 left a comment

This comment was marked as spam.

This comment was marked as spam.

chingor13 left a comment

Allows to use GCE service credentials to sign blobs (#141) #150

Allows to use GCE service credentials to sign blobs (#141) #150

Conversation

dtretyakov commented Feb 27, 2018

googlebot commented Feb 27, 2018

What to do if you already signed the CLA

Individual signers

Corporate signers

dtretyakov commented Feb 27, 2018

googlebot commented Feb 27, 2018

nbali commented May 24, 2018

jeanbza commented May 24, 2018

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

garrettjonesgoogle commented Jun 4, 2018

nbali commented Jun 20, 2018

oss92 commented Jul 2, 2018

chingor13 left a comment

Choose a reason for hiding this comment

This comment was marked as spam.

This comment was marked as spam.

chingor13 left a comment

Choose a reason for hiding this comment