Skip to content

fix: removes-redundant #3095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 16, 2025
Merged

fix: removes-redundant #3095

merged 6 commits into from
Apr 16, 2025

Conversation

Sungyoun-Kim
Copy link
Contributor

@Sungyoun-Kim Sungyoun-Kim commented Apr 3, 2025 •
edited
Loading

  • removes an unnecessary line from the original template used for code generation.

@Sungyoun-Kim Sungyoun-Kim requested a review from a team as a code owner April 3, 2025 07:38
@Sungyoun-Kim Sungyoun-Kim changed the title fix: remove-redundant fix: removes-redundant Apr 3, 2025
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 4, 2025
@codyoss
Copy link
Member

codyoss commented Apr 4, 2025

Please run the update_golden command to regenerate test files and link the the relevant issue.

@Sungyoun-Kim
Copy link
Contributor Author

I didn't realize the issue had already been reported. 😅 (#3001)

@codyoss codyoss mentioned this pull request Apr 7, 2025
Closed
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@quartzmo quartzmo mentioned this pull request Apr 14, 2025
Closed
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2025
@quartzmo quartzmo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2025
@quartzmo quartzmo merged commit 9e9ff11 into googleapis:main Apr 16, 2025
5 checks passed
@quartzmo
Copy link
Member

@Sungyoun-Kim Thank you for this contribution!

@release-please release-please bot mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

@codyoss codyoss codyoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sungyoun-Kim @codyoss @quartzmo @kokoro-team