Skip to content

Bools use lower-case strings in client->server params #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 7, 2017
Merged

Bools use lower-case strings in client->server params #970

merged 6 commits into from
Apr 7, 2017

Conversation

chrisdunelm
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2017
@chrisdunelm
Refactor tests, bring nunit up to date
4198273
@chrisdunelm
Add storage integration test
4262dfe 
Checks pretty printing of response is selected correctly.
@chrisdunelm
Copy link
Contributor Author

The new storage integration test confirms that currently booleans are currently passed incorrectly. This PR passes booleans correctly.
Without the change in this PR, booleans are passed as True/False, which is silently ignored by the server. This PR changes it to true/false, which is accepted as expected by the server.

@chrisdunelm chrisdunelm changed the title [DO NOT MERGE YET] Bools use lower-case strings in client->server params Bools use lower-case strings in client->server params Apr 7, 2017
jskeet
jskeet approved these changes Apr 7, 2017
View reviewed changes
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, but that's all.
I'm assuming all the project changes etc make sense - they all look reasonable, but I'm not going to claim I've checked that they're all required etc.

Src/Support/IntegrationTests_Net45/Helper.cs Outdated

namespace IntegrationTests
{
static class Helper

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Src/Support/IntegrationTests_Net45/Helper.cs Outdated
const string ServiceAccountFilenameVariable = "TEST_SERVICE_CREDENTIAL_FILENAME";
const string ClientSecretFilenameVariable = "TEST_CLIENT_SECRET_FILENAME";

private static Lazy<string> s_projectId = new Lazy<string>(() =>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Src/Support/IntegrationTests_Net45/Helper.cs Outdated
}
});

private static Lazy<byte[]> s_clientSecretStream = new Lazy<byte[]>(() =>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@chrisdunelm chrisdunelm merged commit 9583135 into googleapis:master Apr 7, 2017
@chrisdunelm chrisdunelm deleted the boolcase branch April 7, 2017 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jskeet jskeet jskeet approved these changes

Assignees

@jskeet jskeet

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrisdunelm @jskeet @googlebot