Skip to content

Allow custom URLs in GoogleAuthorizationCodeFlow #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2017

Conversation

chrisdunelm
Copy link
Contributor

Allow authorizationServerUrl and tokenServerUrl to be specified by inheriting from the Initializer.

Fixes #945

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2017
Copy link
Collaborator

@jskeet jskeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Fine with the general approach - a couple of nits.)

: base(GoogleAuthConsts.AuthorizationUrl, GoogleAuthConsts.TokenUrl)
public Initializer() : this(GoogleAuthConsts.AuthorizationUrl, GoogleAuthConsts.TokenUrl) { }

/// <summary>Constructs a new initializer.</summary>

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Allow authorizationServerUrl and tokenServerUrl to be specified by inheriting from the Initializer.

Fixes googleapis#945
@chrisdunelm chrisdunelm merged commit 601a742 into googleapis:master Mar 24, 2017
@chrisdunelm chrisdunelm deleted the custominit branch March 24, 2017 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants