Provide request/response logging

[chrisdunelm]

And provide a MemoryLogger (for testing); and a simple ConsoleLogger.

[jskeet]

Generally fine - a few nits. Will definitely make life nicer.
We may well want a TextWriterLogger some time in the future, but we can add that later.

[chrisdunelm]

Yes, a TextWriterLogger may well be useful later, as might be a DebugLogger and a TraceLogger.
As you say, these can be added later.

[riyadparvez]

How do I enable logging for the client library?

[chrisdunelm]

@riyadparvez Use Google.ApplicationContext.RegisterLogger(...)

Here's an example:

Google.ApplicationContext.RegisterLogger(new Google.Apis.Logging.ConsoleLogger(Google.Apis.Logging.LogLevel.All));
var service = new Google.Apis.Storage.v1.StorageService();
service.HttpClient.MessageHandler.LogEvents |= Google.Apis.Http.ConfigurableMessageHandler.LogEventType.RequestBody;
service.Buckets.List("myProject").Execute();

This code does not successfully call into Google Storage, as there's no authentication; but does show logging to the console. Other loggers are also available.

[riyadparvez]

Thanks for your prompt reply.
This is how I'm initializing the service:

        private GmailService CreateService(string clientId, string clientSecret)
        {
            string credPath = System.Environment.GetFolderPath(
                System.Environment.SpecialFolder.Personal);
            credPath = Path.Combine(credPath, ".credentials/gmail-credentials");

            var credentials = GoogleWebAuthorizationBroker.AuthorizeAsync(
                    new ClientSecrets
                    {
                        ClientId = clientId,
                        ClientSecret = clientSecret,
                    },
                    Constants.Scopes,
                    UserId,
                    CancellationToken.None,
                    new FileDataStore(credPath))
                    .Result;

            Utils.Logger.Debug($"Credential file saved to: {credPath}");

            // We're building the service object, but there's no guarantee that
            // we've logged in or anything
            var service = new GmailService(new BaseClientService.Initializer
            {
                HttpClientInitializer = credentials,
                ApplicationName = "GmailClient",
            })
            {
                HttpClient =
                {
                    MessageHandler =
                    {
                        IsLoggingEnabled = true,
                        LogEvents = ConfigurableMessageHandler.LogEventType.ResponseStatus,
                    },
                    MaxResponseContentBufferSize = Int32.MaxValue ,
                    Timeout = new TimeSpan(0, 0, 200),
                }
            };
            service.HttpClient.MessageHandler.AddExceptionHandler(new HttpExceptionHandler());
            service.HttpClient.MessageHandler.AddUnsuccessfulResponseHandler(new HttpUnsuccessfulResponseHandler());

            Google.ApplicationContext.RegisterLogger(new Google.Apis.Logging.ConsoleLogger(Google.Apis.Logging.LogLevel.All));
            //Google.ApplicationContext.RegisterLogger(new Google.Apis.Logging.MemoryLogger(Google.Apis.Logging.LogLevel.All));
            service.HttpClient.MessageHandler.LogEvents |= Google.Apis.Http.ConfigurableMessageHandler.LogEventType.RequestBody;
            service.HttpClient.MessageHandler.LogEvents |= Google.Apis.Http.ConfigurableMessageHandler.LogEventType.ResponseBody;
            service.HttpClient.MessageHandler.LogEvents |= Google.Apis.Http.ConfigurableMessageHandler.LogEventType.ResponseStatus;
			
            return service;
        }

Unfortunately I still don't see anything on console when I execute API call through the GmailService object.

[chrisdunelm]

Google.ApplicationContext.RegisterLogger must be called very early in your code's execution.

ConfigurableMessageHandler loads the logger the first time it is used, and will not re-load the logger if you subsequently register a logger.

Call RegisterLogger before any code references Google.Apis.*.

[riyadparvez]

Now it works. Thanks for the fix.

[chrisdunelm]

Great :)