Skip to content

Add protected virtual methods to MediaDownloader for closer response inspection #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2016
Merged

Add protected virtual methods to MediaDownloader for closer response inspection #882

merged 1 commit into from
Dec 13, 2016

Conversation

jskeet
Copy link
Collaborator

@jskeet jskeet commented Dec 13, 2016

(This enables hash validation in subclasses.)

No tests as they'd be more longwinded than the code itself, by a considerable margin.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2016
chrisdunelm
chrisdunelm approved these changes Dec 13, 2016
View reviewed changes
Copy link
Contributor

@chrisdunelm chrisdunelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jskeet jskeet merged commit cbcefc0 into googleapis:master Dec 13, 2016
@jskeet jskeet deleted the download branch December 13, 2016 12:45
@jskeet jskeet mentioned this pull request Aug 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdunelm chrisdunelm chrisdunelm approved these changes

Assignees

@chrisdunelm chrisdunelm

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jskeet @chrisdunelm @googlebot