Use Json.NET contract resolver to fix serialization performance issue #1080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit bbab9b9 for issue googleapis#861 introduced (or rather exacerbated) a JSON serialization performance problem with specifying a list of converters via JsonSerializerSettings. From the Json.NET performance tips (https://www.newtonsoft.com/json/help/html/Performance.htm#JsonConverters): > There is, however, a small amount of overhead; the CanConvert method is called for every value to check whether serialization should be handled by that JsonConverter. Before commit bbab9b9 that was only being done for RFC3339DateTimeConverter, which had a relatively quick CanConvert method. Commit bbab9b9 added ExplicitNullConverter with a slower CanConvert method that uses reflection. In my testing with a sizeable data set, JSON serialization was 5x slower and deserialization was 4x slower than before. This change restores the prior JSON serialization performance.
googlebot
added
the
cla: yes
chrisdunelm
approved these changes
Aug 31, 2017
|
We're expecting to release v1.29.1 in the next day or two (mainly to fix #464), which will include this improvement. Thanks :) |
|
v1.29.1, containing this fix, has now been released and pushed to nuget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit bbab9b9 for issue #861 introduced (or rather exacerbated) a JSON serialization performance problem with specifying a list of converters via JsonSerializerSettings.
From the Json.NET performance tips (https://www.newtonsoft.com/json/help/html/Performance.htm#JsonConverters):
Before commit bbab9b9 that was only being done for RFC3339DateTimeConverter, which had a relatively quick CanConvert method. Commit bbab9b9 added ExplicitNullConverter with a slower CanConvert method that uses reflection. In my testing with a sizeable data set, JSON serialization was 5x slower and deserialization was 4x slower than before.
This change restores the prior JSON serialization performance.