GoogleWebAuthorizationBroker.AuthorizeAsync private method should be public

[sguergachi]

I could be wrong, but according to this example on using Oauth says that GoogleWebAuthorizationBroker.AuthorizeAsync should be able to accept a ClientSecrets object instead of a URI: https://developers.google.com/api-client-library/dotnet/guide/aaa_oauth#installed-applications

Here: google-api-dotnet-client/Src/Support/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs the method to support that is private, which breaks that example code.

[chrisdunelm]

Are you referring to this method: https://github.com/google/google-api-dotnet-client/blob/master/Src/Support/GoogleApis.Auth.WP81/OAuth2/GoogleWebAuthorizationBroker.cs#L79 ?
If so, then it does indeed look like an oversite, and should be public.

[sguergachi]

That is correct

[LindaLawton]

Probably links to GoogleWebAuthorizationBroker.AuthorizeAsync doesn't take ClientSecrets in Google.APIs.Auth.OAuth2

[sguergachi]

After updating to the latest release of the nuget package I still seem to run into this issue, this is the code I'm using:

  public async Task authGoogleCloud()
        {
            UserCredential credential;
            using (var stream = new FileStream("client_secrets.json", FileMode.Open, FileAccess.Read))
            {
                credential = await GoogleWebAuthorizationBroker.AuthorizeAsync(
                    GoogleClientSecrets.Load(stream).Secrets, // error on this line
                    new[] { PredictionService.Scope.Prediction },
                    "user", CancellationToken.None);
            }

        }

AuthorizeAsync still seems to require a URI of the secret. I'm targetting UWP, which I realize isn't officially supported yet, but it still seems strange that the public method isn't accessible regardless.

[jskeet]

Hmm... this is probably because there are four different implementations:

• Dotnet4
• WP
• WP81
• Windows

It looks like the last one at least still has the method as private... <sigh>

[chrisdunelm]

I didn't check thoroughly enough last time - I hope they're all now done :)