TokenResponse.Issued set to Now instead of UtcNow

[evildour]

...in TokenResponse.FromHttpResponseAsync

[jskeet]

I'll look at this - using DateTime.Now is almost always a code smell.

In particular, this means any code that tries to check IsExpired may be invalid around a DST transition - in either direction.

I suspect we'll want to add a UtcIssued property, use that everywhere internally, and deprecate Issued... but maintain it for backward compatibility. Urgh.

It might be worth deprecating IClock.Now as well - or at the very least check everywhere it's used internally.

[evildour]

IssuedUtc might be better from a discoverability standpoint since docs/IntelliSense alphabetize, but it does go against the UtcNow/Now convention.

[jskeet]

Indeed - I was wondering that balance myself. Will consider it when we get to this...

[jskeet]

Urgh. It gets worse - this is stored within the authentication store, which will include the DateTime value. Given that two applications could use the same store, one using an old version of the library and one using a new version, we probably need to be able to read from either and store both. Horrible.