Problem while accessing the new XXXDateTimeOffset fields

[DayLightDancer]

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is this a client library issue or a product issue? We will only be able to assist with issues that pertain to the behaviors of this library. If the issue you're experiencing is due to the behavior of the product itself, please visit the Support page to reach the most relevant engineers.

If the support paths suggested above still do not result in a resolution, please provide the following details.

Environment details

• Programming language: C#
• OS: Windows 11
• Language runtime version: Doesn't matter
• Package version: "Google.Apis.AndroidManagement.v1" Version="1.62.1.3210" - Latest for the moment

Steps to reproduce

Create an Enrollment Token
The getter of the ExpirationTimestampDateTimeOffset throws a FormatException. This is because the underlined field is in DateTime format ( it is used in the obsolete ExpirationTimestamp field). Casting that field to the DateTimeOffset throws a FormatException

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

[jskeet]

This is because the underlined field is in DateTime format

Could you clarify exactly what you mean by that?

Casting that field to the DateTimeOffset throws a FormatException

Casting should never throw a FormatException. Please could you show exactly what you mean by providing a code sample?

[jskeet]

(If you could provide the exact value of the ExpirationTimestamp property that you observe at execution time, that would be really helpful.)

[DayLightDancer]

Sample Expiration token:
{
"additionalData": null,
"allowPersonalUsage": "PERSONAL_USAGE_ALLOWED",
"duration": "600s",
"expirationTimestamp": "2023-10-25T15:17:18.224209Z",
"name": "enterprises/XXX/enrollmentTokens/XXX",
"oneTimeOnly": true,
"policyName": "enterprises/XXX/policies/XXX",
"qrCode": "{"android.app.extra.PROVISIONING_DEVICE_ADMIN_COMPONENT_NAME":"com.google.android.apps.work.clouddpc/.receivers.CloudDeviceAdminReceiver","android.app.extra.PROVISIONING_DEVICE_ADMIN_SIGNATURE_CHECKSUM":"I5YvS0O5hXY46mb01BlRjq4oJJGs2kuUcHvVkAPEXlg","android.app.extra.PROVISIONING_DEVICE_ADMIN_PACKAGE_DOWNLOAD_LOCATION":"https://play.google.com/managed/downloadManagingApp?identifier=setup\",\"android.app.extra.PROVISIONING_ADMIN_EXTRAS_BUNDLE\":{\"com.google.android.apps.work.clouddpc.EXTRA_ENROLLMENT_TOKEN\":\"OSYFEYXNZHMBVBSBOKYR\"}}",
"user": {
"accountIdentifier": "XXX",
"ETag": null
},
"value": "XXX",
"ETag": null
}

[jskeet]

Thanks - we should be able to parse "2023-10-25T15:17:18.224209Z" as a DateTimeOffset. I'll look into this tomorrow. If you could provide a sample bit of code that fails, and the complete exception details, that would be great.

[jskeet]

Aha - it looks like the problem is the microsecond precision, which violates the specification at https://developers.google.com/discovery/v1/type-format
We can definitely change the code to parse that, but it's surprising that it's doing it in the first place. I'll ask internally about what's happening.

[DayLightDancer]

This is because the underlined field is in DateTime format

Could you clarify exactly what you mean by that?

Casting that field to the DateTimeOffset throws a FormatException

Casting should never throw a FormatException. Please could you show exactly what you mean by providing a code sample?

I used the debugger to drill down.
The problem as far as I can see is
public virtual System.DateTimeOffset? ExpirationTimestampDateTimeOffset
{
get => Google.Apis.Util.Utilities.GetDateTimeOffsetFromString(ExpirationTimestampRaw);
....
But this field is also set in:
[Newtonsoft.Json.JsonIgnoreAttribute]
[System.ObsoleteAttribute("This property is obsolete and may behave unexpectedly; please use ExpirationTimestampDateTimeOffset instead.")]
public virtual object ExpirationTimestamp
{
get => _expirationTimestamp;
set
{
_expirationTimestampRaw = Google.Apis.Util.Utilities.SerializeForGoogleFormat(value);

and the method SerialzieForGoogleFormat is:
public static string SerializeForGoogleFormat(object value)
{
if (value is null)
{
return null;
}
var json = NewtonsoftJsonSerializer.Instance.Serialize(value);
if (json is null ||
json.Length < 2 ||
!json.StartsWith(""", StringComparison.Ordinal) ||
!json.EndsWith(""", StringComparison.Ordinal))
{
throw new ArgumentException("Value did not serialize to a JSON string.");
}
// Okay, so we have a JSON string. Now we need to parse it to retrieve the actual string value,
// with no conversion to DateTime etc.
return JsonConvert.DeserializeObject(json, s_serializerSettingsWithoutDateParsing);
}

[DayLightDancer]

Aha - it looks like the problem is the microsecond precision, which violates the specification at https://developers.google.com/discovery/v1/type-format We can definitely change the code to parse that, but it's surprising that it's doing it in the first place. I'll ask internally about what's happening.

Thank you. I will apricate this.

[jskeet]

I've started investigating this internally (b/308078684 for any Googlers reading this), but I suspect it may well take a while to resolve. Until that time, I'd suggest using ExpirationTimestampRaw and parsing that with:

DateTimeOffset.ParseExact(raw, "yyyy-MM-dd'T'HH:mm:ss.FFFFFF'Z'", CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal)

That would handle microsecond precision - it won't handle nanosecond precision though; if that turns out to be an issue, we'll need to do more work. Note that setting any DateTimeOffset-based property will only result in millisecond precision at the moment (as that's what we format it to).