Skip to content

chore(deps): Remove deprecated dependency @types/long #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yokotaso
Copy link

@yokotaso yokotaso commented Apr 24, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Description

In my project, I uses @google-analytics/admin.

dependencies like bellow:

npm list long 
├─┬ @google-analytics/[email protected]
│ └─┬ [email protected]
│   ├─┬ @types/[email protected]
│   │ └── [email protected] deduped
│   └─┬ [email protected]
│     └── [email protected] deduped
....

According to @types/long, this package is deprecated.
@types/long itself has no type definition, @types/long is not needed, isn't it?

I got typescript compile error.

> tsc --pretty --noEmit

error TS2688: Cannot find type definition file for 'long'.
 The file is in the program because:
  Entry point for implicit type library 'long'


Found 1 error.

Please provide a detailed description for the change.
As much as possible, please try to keep changes separate by purpose. For example, try not to make a one-line bug fix in a feature request, or add an irrelevant README change to a bug fix.

Impact

What's the impact of this change?

@types/long has no longer any type defenition. so threre would have no impact.

Testing

Have you added unit and integration tests if necessary?
Were any tests changed? Are any breaking changes necessary?

Additional Information

Any additional details that we should be aware of?

Checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease
  • Appropriate docs were updated
  • Appropriate comments were added, particularly in complex areas or places that require background
  • No new warnings or issues will be generated from this change

Fixes #issue_number_goes_here 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 24, 2025
@yokotaso yokotaso marked this pull request as ready for review April 24, 2025 02:51
@yokotaso yokotaso requested review from a team as code owners April 24, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant