feat: add apiVersion to x-goog headers #1576
Conversation
| opts.clientConfig || {}, {'x-goog-api-client': clientHeader.join(' ')}); | ||
| opts.clientConfig || {}, {'x-goog-api-client': clientHeader.join(' ') | ||
| {%- if service.apiVersion -%} | ||
| , 'x-goog-api-version': '{{ service.apiVersion }}' |
There was a problem hiding this comment.
It seems like this change is not covered by baselines, so if it stops working for whatever reason, we won't be able to catch it. Should we add the corresponding annotation to at least one baseline service?
…generator-typescript into addApiVersionToHeaders
|
Here is the summary of possible violations 😱 There are 2 possible violations for not having product prefix.
The end of the violation section. All the stuff below is FYI purposes only. Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
|
I've added the updated protos from here: https://github.com/googleapis/gax-nodejs/blob/main/gax/test/showcase-echo-client/protos/google/showcase/v1beta1/echo.proto So the generated code includes lots of changes that have already been included in the generator, but weren't updated due to old protos. |
see https://docs.google.com/document/d/1ZOrybNB1BUFCFzykqzLuhwL9HHqn0fJV6ZizhVEROxs/edit?tab=t.0
I've manually regenerated showcase and confirmed the headers are sent correctly, as described in the doc above.