executor: refactor struct cover_t #5809
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramosian-glider
force-pushed
the
kcov_dedup
branch
from
b542ac4 to
5ea9679
Compare
Instead of having a single `void *data` pointer that is used to both allocate the memory and access the trace, split it into: - `void *alloc` of size `mmap_alloc_size`, used by mmap/munmap to manage the memory for kcov (may contain other data apart from the trace) - `void *trace` of size `trace_size`, used to access the collected trace Future patches will introduce other collection modes that may relocate the trace, so `alloc` and `trace` won't be interchangeable anymore. Also rename `trace_offset` to `trace_skip`. From now on, `XXX_offset` is the offset of `XXX` from the beginning of `alloc`, and `trace_skip` is the number of bytes to skip from the beginning of the trace to get to the actual PCs. I tried my best to not break Darwin and BSD, but I didn't test them.
ramosian-glider
force-pushed
the
kcov_dedup
branch
from
5ea9679 to
25a61fe
Compare
|
FTR: there might happen some conflict between the changes from this PR and #5799 |
Thanks for the heads-up! I will incorporate their changes once they land. |
dvyukov
reviewed
Feb 24, 2025
| void* alloc; | ||
| // Buffer used by kcov for collecting PCs. | ||
| char* trace; | ||
| uint32 trace_size; |
There was a problem hiding this comment.
Let's keep only trace_end.
| cov->data_offset = is_kernel_64_bit ? sizeof(uint64_t) : sizeof(uint32_t); | ||
| cov->trace_offset = 0; | ||
| cov->trace = (char*)cov->alloc; | ||
| // TODO(glider): trace size and may be different from mmap_alloc_size in the future. |
There was a problem hiding this comment.
This does not look useful as TODO in the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having a single void *data pointer that is used to both allocate the memory and access the trace, split it into:
Future patches will introduce other collection modes that may relocate the trace, so *alloc and *trace won't be interchangeable anymore.
I tried my best to not break Darwin and BSD, but I didn't test them.
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md