-
Notifications
You must be signed in to change notification settings - Fork 1.3k
dashboard: debug a dupped report inaccessibility #5856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
syzkaller/dashboard/app/main.go Lines 1058 to 1060 in 89d30d7
we should probably first call @dvyukov are you aware of any cases when it would be undesirable? |
As far as I remember, such duping was not supposed to happen. Just opening visibility for the duped bug creates several problems:
The idea was that one needs to upstream both reports and then do duping in public (or at least the duped bug must be in public moderation). This removes at least part of the above questions. But I can't find the code/tests that actually implements the restriction. |
I do remember the checks that restrict the duping across the namespaces (which is totally reasonable) and across the reporting stages, but not the deduplication of reports before upstreaming them. I think that, as long as we display all the information on our web dashboard, it should be totally fine to deduplicate before publishing. And maybe even better to do so - do we really want to clutter the mailing lists with unnecessary emails? |
If you feel it's the right thing to do, let's remove restrictions on duping across stages and use canonical bug for accessibility. |
https://syzkaller.appspot.com/bug?id=708d072d882f769d835eaf9eaefdc86406462ef4
The report was deduplicated to https://syzkaller.appspot.com/bug?extid=353d7b75658a95aa955a, which is upstreamed and available to anyone.
But, for some reason, the original bug report is still non-public.
Another question is why the instance is marked as "failing", even though the failure is gone.
The text was updated successfully, but these errors were encountered: