Skip to content

dashboard: debug a dupped report inaccessibility #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-nogikh opened this issue Mar 24, 2025 · 4 comments
Open

dashboard: debug a dupped report inaccessibility #5856

a-nogikh opened this issue Mar 24, 2025 · 4 comments
Labels

Comments

@a-nogikh
Copy link
Collaborator

a-nogikh commented Mar 24, 2025

https://syzkaller.appspot.com/bug?id=708d072d882f769d835eaf9eaefdc86406462ef4

The report was deduplicated to https://syzkaller.appspot.com/bug?extid=353d7b75658a95aa955a, which is upstreamed and available to anyone.

But, for some reason, the original bug report is still non-public.


Another question is why the instance is marked as "failing", even though the failure is gone.

@a-nogikh a-nogikh added the bug label Mar 24, 2025
@a-nogikh
Copy link
Collaborator Author

if err := checkAccessLevel(c, r, bug.sanitizeAccess(c, accessLevel)); err != nil {
return err
}

we should probably first call canonicalBug(c, bug) here.

@dvyukov are you aware of any cases when it would be undesirable?

@dvyukov
Copy link
Collaborator

dvyukov commented Mar 26, 2025

As far as I remember, such duping was not supposed to happen. Just opening visibility for the duped bug creates several problems:

  • upstream developers never seen the duped report, nor even know that something was duped onto a reported bug
  • upstream developers may not be able to debug the reported bug since they don't have/see all info
  • upstream developers may not agree with the duping, but again have not even seen it happened
  • upstream developers may have a natural question as to where/who did the duping

The idea was that one needs to upstream both reports and then do duping in public (or at least the duped bug must be in public moderation). This removes at least part of the above questions.

But I can't find the code/tests that actually implements the restriction.

@a-nogikh
Copy link
Collaborator Author

a-nogikh commented Apr 2, 2025

I do remember the checks that restrict the duping across the namespaces (which is totally reasonable) and across the reporting stages, but not the deduplication of reports before upstreaming them.

I think that, as long as we display all the information on our web dashboard, it should be totally fine to deduplicate before publishing. And maybe even better to do so - do we really want to clutter the mailing lists with unnecessary emails?

@dvyukov
Copy link
Collaborator

dvyukov commented Apr 2, 2025

If you feel it's the right thing to do, let's remove restrictions on duping across stages and use canonical bug for accessibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants