Skip to content

Clean up build infra issues. #7199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2022
Merged

Clean up build infra issues. #7199

merged 2 commits into from
Jan 31, 2022

Conversation

jonathanmetzman
Copy link
Contributor

  1. Don't clone fuzz-introspector to /src since it breaks builds.
  2. Install packages in python install script properly. Previously
    pip install atheris>=2.0.6 was interpreted as "redirect the output
    from pip install atheris" to the file "=2.0.6".
  3. Clean up some miscellanious issues.

@jonathanmetzman
Clean up build infra issues.
7f6aecb 
0. Don't clone fuzz-introspector to /src since it breaks builds.
1. Install packages in python install script properly. Previously
pip install atheris>=2.0.6 was interpreted as "redirect the output
from pip install atheris" to the file "=2.0.6".
3. Clean up some miscellanious issues.
@jonathanmetzman
Copy link
Contributor Author

I assume this will break fuzz-introspector somewhere, but I'm not sure where. It should be easy to fix though and I don't think we need to block this PR on adjusting that code since FI isn't production code yet.

DavidKorczynski
DavidKorczynski reviewed Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not sure if I missed something, but where is the change that causes fuzz-introspector not to cloned in /src (change num 0 you mention)? I can't spot the diff that causes this?

@jonathanmetzman
Copy link
Contributor Author

Am not sure if I missed something, but where is the change that causes fuzz-introspector not to cloned in /src (change num 0 you mention)? I can't spot the diff that causes this?

You're not missing anything. I am 🤦 I forgot to include it.
Fixed!

@DavidKorczynski
Copy link
Collaborator

Am not sure if I missed something, but where is the change that causes fuzz-introspector not to cloned in /src (change num 0 you mention)? I can't spot the diff that causes this?

You're not missing anything. I am facepalm I forgot to include it. Fixed!

ah cool! lgtm!

@jonathanmetzman
Copy link
Contributor Author

Hmm...maybe I'll rewrite this to only include the introspector removal so we don't break anything.
Kinda torn about merging this now. On the one hand: build fixes good, on the other: patches before the weekend bad

This was referenced Jan 30, 2022
Merged
Closed
@oliverchang
Copy link
Collaborator

Thanks @jonathanmetzman ! Let's try this.

@oliverchang oliverchang merged commit 3610c9d into master Jan 31, 2022
@oliverchang oliverchang deleted the fix-fi branch January 31, 2022 00:57
@jonathanmetzman jonathanmetzman mentioned this pull request Feb 1, 2022
Closed
@radarhere radarhere mentioned this pull request Feb 1, 2022
Merged
@Navidem Navidem mentioned this pull request Feb 3, 2022
Merged
DonggeLiu pushed a commit that referenced this pull request Feb 3, 2022
@jonathanmetzman @DonggeLiu
Clean up build infra issues. (#7199)
4eee267 
* Clean up build infra issues.

0. Don't clone fuzz-introspector to /src since it breaks builds.
1. Install packages in python install script properly. Previously
pip install atheris>=2.0.6 was interpreted as "redirect the output
from pip install atheris" to the file "=2.0.6".
3. Clean up some miscellanious issues.

* Include removal
MartinPetkov pushed a commit to MartinPetkov/oss-fuzz that referenced this pull request Aug 15, 2022
@jonathanmetzman @MartinPetkov
Clean up build infra issues. (google#7199)
e5ca0e5 
* Clean up build infra issues.

0. Don't clone fuzz-introspector to /src since it breaks builds.
1. Install packages in python install script properly. Previously
pip install atheris>=2.0.6 was interpreted as "redirect the output
from pip install atheris" to the file "=2.0.6".
3. Clean up some miscellanious issues.

* Include removal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidKorczynski DavidKorczynski DavidKorczynski approved these changes

@Navidem Navidem Navidem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanmetzman @DavidKorczynski @oliverchang @Navidem