Dynamic hotspots #3981
Merged
Dynamic hotspots #3981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
* switch to three.js reduceVertices * cleanup and refactor of fromPoint methods * implementation complete * updated editor to dynamic hotspots * position working * added normals * fixed editor tests * added test * added docs * added example * update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053
I'm pretty happy with how this feature turned out; I even wrote up an example for it, which looks like this:
Screen.Recording.2022-12-01.at.9.32.17.PM.mov
This PR is blocked on a PR I've put in to three.js: mrdoob/three.js#25049 so this'll have to wait at least a month before I can merge it, since I'll need to wait for r148. Also, this will change how the editor creates hotspots, so I'd like to release fairly shortly after I merge this so we don't get a lot of questions about why MV 2.1 isn't compatible with the editor.