More and more refactoring. #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
October 29, 2022 18:20
added 2 commits
October 31, 2022 11:35
ryosuketc
reviewed
Oct 31, 2022
| if lstr is None: | ||
| lstr = r"\mathrm{" + callee_str + r"}\left(" | ||
| rstr = r"\right)" | ||
| if func_str in ("sum", "prod") and isinstance(node.args[0], ast.GeneratorExp): |
There was a problem hiding this comment.
sum / prod handler here LGTM.
ShigekiKarita
approved these changes
Nov 1, 2022
| r"\mathrm{f}(x) \triangleq " | ||
| r"{3}\left( \left( x^{{2}} \right) + \left( x^{{2}} \right) \right)" | ||
|
|
||
| def test_reduce_assignments_with_if() -> None: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
reduce_assignmentsbehavior totransformers/AssignmentReducer.NodeVisitorBaseimplementation.LatexifyVisitortocodegen/FunctionCodegenDetails
Substitution sign
amssymbpackage is loaded, which is not compatible with the bare LaTeX. This behavior often confuses users who try to compile the obtained LaTeX source by themselves.The sign is replaced to$=$ at this point, because I thought that this sign is the most neutral choice to every user.
We may further need to provide some flags to replace this sign by users.
Other refactoring
This change improves the modulability of the whole library.
The
visit_*functions in the newFunctionCodegenvisitor returns alwaysstr, while ad-hoc processes are moved away to the new AST transformerAssignmentReduceror some private functions.AssignmentReducerdirectly modifies the AST by replacing subtrees with substitution. This could reduce some unnecessary parenthesis pairs\left(and\right)caused by ad-hoc processing in the old Visitor.This change also removes all "actions" from the original Visitor so that we can use the standard
ast.NodeVisitoras the base class of the codegen.References
Blocked by
NA