Skip to content

Improve visit_Compare implementation #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2022
Merged

Improve visit_Compare implementation #61

merged 2 commits into from
Oct 24, 2022

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Oct 22, 2022 •
edited
Loading

This change introduces following changes:

  • Add support for is not, in, not in operators. This includes cherrypicks of Add some comprehensions and set operations #59.
  • Change the generated syntax from a=b, a\op b to {a = b}, {a \op b}.
  • Support multiple comparators: a == b == c to {a = b = c}.

@odashi odashi added this to the v0.2 milestone Oct 22, 2022
@odashi odashi requested a review from ShigekiKarita October 22, 2022 17:15
ShigekiKarita
ShigekiKarita reviewed Oct 23, 2022
View reviewed changes
ShigekiKarita
ShigekiKarita approved these changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@ShigekiKarita ShigekiKarita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odashi odashi requested a review from ShigekiKarita October 23, 2022 07:46
@odashi odashi mentioned this pull request Oct 23, 2022
Merged
@odashi odashi merged commit c881cce into main Oct 24, 2022
@odashi odashi deleted the add-in-op branch October 24, 2022 01:56
@odashi odashi added the feature label Oct 24, 2022
@odashi odashi mentioned this pull request Oct 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShigekiKarita ShigekiKarita Awaiting requested review from ShigekiKarita

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@odashi @ShigekiKarita