Skip to content

Move expand_functions to Config #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2022
Merged

Move expand_functions to Config #133

merged 1 commit into from
Nov 24, 2022

Conversation

odashi
Copy link
Collaborator

@odashi odashi commented Nov 23, 2022

Overview

Follow-up of #103 and #125: Adds expand_functions to Config.

@odashi odashi added this to the v0.3 milestone Nov 23, 2022
@odashi odashi requested a review from ShigekiKarita November 23, 2022 07:13
@odashi odashi changed the title move config Move expand_functions to Config Nov 23, 2022
ZibingZhang
ZibingZhang approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@ZibingZhang ZibingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe out of the scope of this PR, but might be nice to allow users to somehow specify custom function expansions

@odashi
Copy link
Collaborator Author

odashi commented Nov 23, 2022

@ZibingZhang As you said it is off-topic here, could you make another issue for it?

@odashi odashi merged commit b93376b into main Nov 24, 2022
@odashi odashi deleted the move-config branch November 24, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShigekiKarita ShigekiKarita ShigekiKarita approved these changes

@ZibingZhang ZibingZhang ZibingZhang approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@odashi @ShigekiKarita @ZibingZhang