Add MethodHandle support to @Inject constructors/field/methods.
#1888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This is the most complicated one since it uses a long tail of rarer features (InjectionListeners, member injection). But mostly it builds on established patterns so the trickiest part was actually getting the exception handling correct, luckily this is pretty well tested! With this there is enough to start broad based testing. Beyond this there are open questions about how to handle various member injection APIs for which I have left some TODOs PiperOrigin-RevId: 740475465
copybara-service
bot
force-pushed
the
test_739964636
branch
from
82ca5ea to
b8dc884
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MethodHandle support to
@Injectconstructors/field/methods.This is the most complicated one since it uses a long tail of rarer features (InjectionListeners, member injection). But mostly it builds on established patterns so the trickiest part was actually getting the exception handling correct, luckily this is pretty well tested!
With this there is enough to start broad based testing. Beyond this there are open questions about how to handle various member injection APIs for which I have left some TODOs