Skip to content

Resolve daemon warnings for threading methods #1134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

Description

This small PR resolve the deprecation warnings of daemon for threading methods:

/home/runner/work/grr/grr/grr/client/grr_response_client/client_utils_common.py:105: DeprecationWarning: setDaemon() is deprecated, set the daemon attribute instead

@emmanuel-ferdman
Copy link
Contributor Author

Hi @mbushkov, can you please review this small PR when you get the chance? thanks 🙌

@mbushkov
Copy link
Collaborator

Hi @mbushkov, can you please review this small PR when you get the chance? thanks 🙌

Hi @emmanuel-ferdman ! Thank you for the fix and sorry for the delayed review.

@mbushkov mbushkov merged commit 545bdea into google:master May 22, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants